Add test for partial #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-jake-jake
commented
Dec 31, 2024
| (t/is (= 3 (simple-use)))) | ||
| (let [lazily-evaluated (partial inc 2 3)] | ||
| #?(:clj (t/is (thrown? Exception (lazily-evaluated))) | ||
| :cljs (t/is (thrown? js/Error (lazily-evaluated))))) |
There was a problem hiding this comment.
I don't know if handling the JS case is needed, but I thought I'd add this. I can remove if that makes more sense.
jeaye
reviewed
Jan 2, 2025
test/clojure/core_test/partial.cljc
Outdated
| (defn test-fn [& args] | ||
| (into [] args)) | ||
|
|
||
| (t/deftest test-partial [] |
There was a problem hiding this comment.
What do you think about:
- Chaining partials
- Including lazy sequences
- A partial partial
There was a problem hiding this comment.
Happy to add some more cases.
For 2, I am pushing up a test that has an infinite sequence and takes from it. If that's not quite right let me know.
For 1, do you mean a sequence of partials? I included what could be a test for that, but also, if that's not quite right let me know.
There was a problem hiding this comment.
- You got this one
- Looks good
- I was thinking something like
(((partial partial) +) 0 5)
Seemed like a good edge case to cover.
There was a problem hiding this comment.
Totally. I adjusted the partial-partial tests. Lemme know any other adjustments.
|
Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.